Open
Conversation
|
@khmyznikov FYI |
|
@Harishmcw tests are fine? |
Author
Yes, the tests are fine. The previous failures were due to a regression on newer Windows Server 2025 runners, which this PR addresses. The pipeline is now green across all platforms, and I've verified that the Windows ARM64 tests are also passing correctly: pipeline |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces official support for Windows ARM64.
Changes:
soundfile.pyto correctly detect ARM64/AArch64 architectures on Windows and load the correspondinglibsndfile_arm64.dll.windows-11-armto the GitHub Actions matrix and included arm64 architecture across supported OS versions.